Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: solve remaining clippy warnings and add it to CI#487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 6 commits intorust-lang:mainfromCosminPerRam:feat/clippy_happy
Apr 28, 2025

Conversation

CosminPerRam
Copy link
Contributor

Other than quite a few usages of#[allow(clippy::unnecessary_cast)] cause clippy can't fully see the full picture, things look fine to me.
Many of my contributions contained clippy warning fixes and this PR solves all of the remaining ones and adds check for them to CI (as errors).

Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot, much appreciated.

The#[allow(clippy::unnecessary_cast)] is a bit puzzling to me, but it's nothing to hold the PR up over.

@ByronByron merged commitc2c78de intorust-lang:mainApr 28, 2025
14 checks passed
@CosminPerRam
Copy link
ContributorAuthor

If we try to cast a declaration to the same type as itself (A) that's an unnecessary cast, this lint tries to prevent stuff like this, but Clippy can't always see the full picture (in our case, different definitions behind feature flags, in a place we use type A and somewhere its type B, in this case Clippy sees only the first case, so it thinks we are making an unnecessary cast but we actually dont.

Byron reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@CosminPerRam@Byron

[8]ページ先頭

©2009-2025 Movatter.jp