- Notifications
You must be signed in to change notification settings - Fork180
feat: solve remaining clippy warnings and add it to CI#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot, much appreciated.
The#[allow(clippy::unnecessary_cast)]
is a bit puzzling to me, but it's nothing to hold the PR up over.
c2c78de
intorust-lang:mainUh oh!
There was an error while loading.Please reload this page.
If we try to cast a declaration to the same type as itself (A) that's an unnecessary cast, this lint tries to prevent stuff like this, but Clippy can't always see the full picture (in our case, different definitions behind feature flags, in a place we use type A and somewhere its type B, in this case Clippy sees only the first case, so it thinks we are making an unnecessary cast but we actually dont. |
Other than quite a few usages of
#[allow(clippy::unnecessary_cast)]
cause clippy can't fully see the full picture, things look fine to me.Many of my contributions contained clippy warning fixes and this PR solves all of the remaining ones and adds check for them to CI (as errors).