- Notifications
You must be signed in to change notification settings - Fork97
Add tools version of containers#122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Trolldemorted commentedOct 11, 2023
I'm sorry that I won't be able to help as I'm not a maintainer of this repository, so I have no ability to accept or reject this PR. That being said saying "or is this repository abandonware except for the version bumps" is both incorrect (there have been PRs that add things) and it can be off-putting to maintainers, hurting your cause. We have no idea what is going on in their day to day lives, or how much time they have to commit to maintaining this repository. I understand it can be frustrating for a PR to be open for a long time with no decision on what to do with it. A better way to handle this situation is to ask politely for a review and if you feel up to it, give more context for why the PR is wanted in the first place. |
I'm also not a maintainer of this repository. Personally, this feature is my wish too, but I strongly agree with Muscraft that a polite request should be made. |
| @@ -0,0 +1,3 @@ | |||
| FROM rust:%%RUST-IMAGE%% | |||
| RUN rustup component add rustfmt clippy llvm-tools-preview | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Christiaan676 I think this is now available asllvm-tools directly without the preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This indeed seems to be the case. (https://rust-lang.github.io/rustup/concepts/components.html).
This merge request is already more than a year old. I'm willing to update it and change things if needed, but only if a maintainer is wiling to review and eventually merge it. Currently updating it seems to be a wast of my time.
Adds a tools version of the containers, that adds the following rust components: rustfmt, clippy and llvm-tools-preview. More rust components could be added. But this seams to me the most applicable set for CI.
Al lot of firsts in this pull-request so let me know if I need to change something.
Solves issue:#97