- Notifications
You must be signed in to change notification settings - Fork655
WIP sekrit project#10610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
carols10cents wants to merge6 commits intorust-lang:mainChoose a base branch fromcarols10cents:more-logins
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
WIP sekrit project#10610
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7d91bcc
toe072a0c
Comparea31b6fa
to6c9d8ff
CompareThat has a `provider` column that will (for now) always be set to 0,which corresponds to `AccountProvider::Github`.The table's primary key is (provider, account_id), which corresponds to(0, gh_id). This constraint will mean a particular GitHub/GitLab/etcaccount, identified from the provider by an ID, may only be associatedwith one crates.io user record, but a crates.io user record could(eventually) have *both* a GitHub *and* a GitLab account associated withit (or two GitHub accounts, even!)This is the first step of many to eventually allow for crates.ioaccounts linked to other OAuth providers in addition/instead of GitHub.No code aside from one test is reading from the linked accounts table atthis time.No backfill has been done yet.No handling of creating/associating multiple OAuth accounts with onecrates.io account has been done yet.
Right now, this will always have the same value as gh_login on the userstable and login on the linked accounts table. All of these values willget updated when we get a new gh_login value.Eventually, we're going to have to decouple the concept of crates.io"username" from the logins of the various account(s), which you may ormay not want to update when you update your GitHub or other login, andwhich may or may not conflict with other users' crates.io usernames.But for now, set up for that future and defer the harder decisions untillater by making this field always get the same value as gh_login.This adds a `username` field to the JSON views returned from the API butdoes not use that field anywhere yet.Question: should team owner JSON also have a field named `username` asdone in this commit? it's a little weird for a team to have a usernamebecause it's not a user. but it's consistent. something more genericlike `name` might also be confusing. something more specific like`crates_io_identifier` is more verbose but less confusable. shrug
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.