- Notifications
You must be signed in to change notification settings - Fork655
controllers/version: Add traits to help reduce data loading#10603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
eth3lbert wants to merge5 commits intorust-lang:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Instead of loading them individually, this gets both in one query.I think that in most cases, the request to query for `Crate` and`Version` will have valid input, so this seems like a better approach,even though it might only give a small performance boost.
…`crate_and_version()` fnSince most endpoints don't need all of the columns for `crates` and`versions`, it would be great to only load the columns we actually needto make things faster.This will enable other endpoints to use the function to make a basequery and customize the needed columns.
ffff496 to1028929CompareRebased and conflict resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm somewhat unsure whether the extra complexity is worth it.@LawnGnome any opinions?
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
A-backend ⚙️C-enhancement ✨Category: Adding new behavior or a change to the way an existing feature works C-internal 🔧Category: Nonessential work that would make the codebase more consistent or clear
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR primarily addresses three things:
CrateandVersionin a single query.Cratewhen onlyVersionis needed.First, I assume that in most cases, the given inputs are valid, then it would be great to load them in a single query.
Second, since most endpoints do not require all columns from
CrateandVersion, it would be nice to load only the necessary columns to reduce data loading.Third, when only
Versionis required, it would be ideal to load only the ID ofCrateto determine its existence.I hope this doesn't overly complicate things :)