- Notifications
You must be signed in to change notification settings - Fork243
Don't callrust_begin_unwind#802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
tgross35 wants to merge4 commits intorust-lang:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c7127cb to20a6f93Compare`builtins-test-intrinsics` has long included a call to an unmangled`rust_begin_unwind` (the name `rustc` gives the `#[panic_handler]`),since [1], which I believe was intended to ensure panic machinery linkscorrectly. However, since [2], `rust_begin_unwind` is mangled andunavailable for calling directly, which explains the recent CI failures.Instead of calling the function directly, we can just panic; do so here.Additionally, put this call behind `black_box(false)` rather thanunconditional, which means we can run the binary and ensure there are noruntime issues.[1]:rust-lang#360[2]:rust-lang/rust#127173
20a6f93 to3ed644aCompareNow I see why this was done rather than calling |
tgross35 added a commit to tgross35/compiler-builtins that referenced this pull requestMar 19, 2025
Since [1] this symbol is mangled, meaning it is not easy to calldirectly. A better fix will come in [2] but for now, just disable thatportion of the test.[1]:rust-lang/rust#127173[2]:rust-lang#802
tgross35 added a commit that referenced this pull requestMar 19, 2025
Since [1] this symbol is mangled, meaning it is not easy to calldirectly. A better fix will come in [2] but for now, just disable thatportion of the test.[1]:rust-lang/rust#127173[2]:#802
tgross35 added a commit to tgross35/rust that referenced this pull requestJun 3, 2025
Since [1] this symbol is mangled, meaning it is not easy to calldirectly. A better fix will come in [2] but for now, just disable thatportion of the test.[1]:rust-lang#127173[2]:rust-lang/compiler-builtins#802
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull requestJun 17, 2025
Since [1] this symbol is mangled, meaning it is not easy to calldirectly. A better fix will come in [2] but for now, just disable thatportion of the test.[1]:rust-lang#127173[2]:rust-lang/compiler-builtins#802
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.