- Notifications
You must be signed in to change notification settings - Fork243
Add integer tof16 conversions#729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
tgross35 wants to merge1 commit intorust-lang:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7230b09 tod2d4f22Comparetgross35 added a commit to tgross35/compiler-builtins that referenced this pull requestNov 5, 2024
CI in [1] seems to indicate that there are cases where the `f16`infinite recursion bug ([2], [3]) can make its way into what gets calledduring tests, even though this doesn't seem to be the usual case. Inorder to make sure that we avoid these completely, just unset`f16_enabled` on any platforms that have the recursion problem.This also refactors the `match` statement to be more in line with`library/std/build.rs`.[1]:rust-lang#729[2]:llvm/llvm-project#97981[3]:rust-lang#651
1a86a8d tof6a5429CompareIncludes#730 since PPC crashes without it. |
These are not present in LLVM's `compiler-rt` but LLVM does emit them insome cases [1].[1]:rust-lang/rust#132614 (comment)
92 tasks
tgross35 added a commit to tgross35/rust that referenced this pull requestJun 3, 2025
CI in [1] seems to indicate that there are cases where the `f16`infinite recursion bug ([2], [3]) can make its way into what gets calledduring tests, even though this doesn't seem to be the usual case. Inorder to make sure that we avoid these completely, just unset`f16_enabled` on any platforms that have the recursion problem.This also refactors the `match` statement to be more in line with`library/std/build.rs`.[1]:rust-lang/compiler-builtins#729[2]:llvm/llvm-project#97981[3]:rust-lang/compiler-builtins#651
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull requestJun 17, 2025
CI in [1] seems to indicate that there are cases where the `f16`infinite recursion bug ([2], [3]) can make its way into what gets calledduring tests, even though this doesn't seem to be the usual case. Inorder to make sure that we avoid these completely, just unset`f16_enabled` on any platforms that have the recursion problem.This also refactors the `match` statement to be more in line with`library/std/build.rs`.[1]:rust-lang/compiler-builtins#729[2]:llvm/llvm-project#97981[3]:rust-lang/compiler-builtins#651
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not present in LLVM's
compiler-rtbut LLVM does emit them in some cases1.