- Notifications
You must be signed in to change notification settings - Fork243
Make all linker warnings errors in CI#667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Failure notes:
|
For MSVC it's |
Does it ignore unrecognized link args? |
I mean...
|
Oh, unrecognized linker args are warnings by default rather than errors? I was just expecting it to complain like the other targets that don't support |
The wasm issue isrust-lang/rust#132802, I still haven't updated the Windows flags. |
Give us a better chance of detecting any kind of link issues oruser-visible warnings in advance.
Uh oh!
There was an error while loading.Please reload this page.
Give us a better chance of detecting any kind of link issues or user-visible warnings in advance.
Inspired by#665 (comment)