Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make all linker warnings errors in CI#667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
tgross35 wants to merge1 commit intorust-lang:master
base:master
Choose a base branch
Loading
fromtgross35:linker-errors

Conversation

tgross35
Copy link
Contributor

@tgross35tgross35 commentedAug 11, 2024
edited
Loading

Give us a better chance of detecting any kind of link issues or user-visible warnings in advance.

Inspired by#665 (comment)

@tgross35tgross35 changed the titleMake all linker warnings errors[experiment] Make all linker warnings errorsAug 12, 2024
@tgross35
Copy link
ContributorAuthor

Failure notes:

@ChrisDenton
Copy link
Member

For MSVC it's/WX

tgross35 reacted with heart emoji

@tgross35
Copy link
ContributorAuthor

Does it ignore unrecognized link args?fatal-warnings is still getting passed and it doesn't seem to complainhttps://github.com/rust-lang/compiler-builtins/actions/runs/10343839608/job/28628523945?pr=667#step:11:23

@ChrisDenton
Copy link
Member

I mean.../Wx isn't being passed yet?

> rustc hello.rs -C link-args='/WX --fatal-warnings'error: linking with `link.exe` failed: exit code: 4044[...]  = note: LINK : warning LNK4044: unrecognized option '/-fatal-warnings'; ignored          LINK : error LNK1218: warning treated as error; no output file generated

@tgross35
Copy link
ContributorAuthor

Oh, unrecognized linker args are warnings by default rather than errors? I was just expecting it to complain like the other targets that don't support-Wl,--fatal-warnings do.

@tgross35tgross35 changed the title[experiment] Make all linker warnings errorsMake all linker warnings errors in CISep 28, 2024
@tgross35
Copy link
ContributorAuthor

The wasm issue isrust-lang/rust#132802, I still haven't updated the Windows flags.

Give us a better chance of detecting any kind of link issues oruser-visible warnings in advance.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tgross35@ChrisDenton

[8]ページ先頭

©2009-2025 Movatter.jp