- Notifications
You must be signed in to change notification settings - Fork47
fix: Properly handle annotating leading whitespace#334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
epage merged 3 commits intorust-lang:masterfromMuscraft:fix-annotating-leading-whitespaceOct 28, 2025
Merged
fix: Properly handle annotating leading whitespace#334
epage merged 3 commits intorust-lang:masterfromMuscraft:fix-annotating-leading-whitespaceOct 28, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ffa5268 intorust-lang:master 14 of 15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustchas a test for annotating ano-break space near the start of a line with whitespace following it.annotate-snippetscurrently fails this test because it usesstd::char::is_whitespacefor calculatingwhitespace_left, which treatsno-break space as whitespace, leadingwhitespace_leftto be larger thanlabel_right, which causes a subtract with overflow panic.rustcgets around this by usingrustc_parse::is_whitespace, which does not treat a no-break space as whitespace. That solution only masks the problem, as it would still panic when annotating whitespace chars with more whitespace following them. Instead, this PR fixes theMargincalculations to allow annotating whitespace before more whitespace.