- Notifications
You must be signed in to change notification settings - Fork47
fix: Properly calculate the max line num for suggestions#323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
src/snippet.rs Outdated
| /// A whitespace [`Element`] in a [`Group`] | ||
| #[derive(Clone,Debug)] | ||
| #[derive(Clone,Copy,Debug)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are we sure we want to have this from an API perspective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is probably something we should put more thought into, so I will drop it from this PR.
526149a to8e9817bCompare450b2ea intorust-lang:masterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There were some cases where we were not calculating the correct max line number for suggests, this PR addresses those problems.