Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix no copy when castSnippet toDisplayList and #29#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zbraniecki merged 2 commits intorust-lang:masterfromzzau13:master
Apr 4, 2020
Merged

Fix no copy when castSnippet toDisplayList and #29#32

zbraniecki merged 2 commits intorust-lang:masterfromzzau13:master
Apr 4, 2020

Conversation

@zzau13
Copy link
Contributor

With this pull request the "no copy" process is completed. All the crate is free copy 😄
I have changed fromyaml totoml becauseyaml does not implementserde::Deserialize

zbraniecki reacted with heart emoji
@zbranieckizbraniecki self-requested a reviewApril 3, 2020 21:41
@zzau13
Copy link
ContributorAuthor

Fixed#29

let lines = slice.source.lines();
let lines_len = lines.clone().count();
for(i, line)in lines.enumerate(){
for(line, end_line)inCursorLines::new(slice.source){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I really like this solution!

zzau13 reacted with heart emoji
@zzau13zzau13 changed the titleFix no copy when castSnippet toDisplayListFix no copy when castSnippet toDisplayList and #29Apr 4, 2020
@zbraniecki
Copy link
Contributor

Looks great! Thank you!

@zbranieckizbraniecki merged commitc66d784 intorust-lang:masterApr 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@zbranieckizbranieckizbraniecki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zzau13@zbraniecki

[8]ページ先頭

©2009-2025 Movatter.jp