Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Removeasm_const attribute because it is no longer required#220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ChocolateLoverRaj wants to merge2 commits intorust-embedded:master
base:master
Choose a base branch
Loading
fromChocolateLoverRaj:asm-const-stable

Conversation

ChocolateLoverRaj
Copy link

@ChocolateLoverRajChocolateLoverRaj commentedOct 18, 2024
edited
Loading

Description

I got this error:

error: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable   --> src/main.rs:109:12    |109 | #![feature(asm_const)]    |            ^^^^^^^^^    |    = note: `-D stable-features` implied by `-D warnings`    = help: to override `-D warnings` add `#[allow(stable_features)]`

so I removed the line and created this PR. I tested it in QEMU and it worked. Real HW raspberry Pi is not applicable since it's just tutorial 2.

Pre-commit steps

  • Tested on QEMU and real HW Rasperry Pi.
    • Not needed if it is just a README change or similar.
  • Ran./contributor_setup.sh followed by./devtool ready_for_publish
    • You'll needRuby withBundler andNPM installed locally.
    • If no Rust-related files were changed,./devtool ready_for_publish_no_rust can be used instead (faster).
    • This step is optional, but much appreciated if done.

@jannic
Copy link
Member

If we rely on recent features, we probably need to updatehttps://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/rust-toolchain.toml as well.

ChocolateLoverRaj reacted with thumbs up emoji

@ChocolateLoverRaj
Copy link
Author

I updated the toolchain. As I go through the tutorials there are more things that need to be changed to work with the latest Rust version. Should I make a PR that updates all tutorials to work? Is there a shortcut for having to modify changes from03 that also need to be changed from04 to20?

@BartMassey
Copy link
Member

I would suggest that you fork this tutorial and work on a branch, fixing things as you go with one commit per fix. Then submit a PR to bring your branch to mainline and we can discuss it.

@ChocolateLoverRajChocolateLoverRaj marked this pull request as draftNovember 7, 2024 01:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ChocolateLoverRaj@jannic@BartMassey

[8]ページ先頭

©2009-2025 Movatter.jp