Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix cc wrappers (revert #197)#210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fbeutel wants to merge3 commits intorust-embedded:master
base:master
Choose a base branch
Loading
fromfbeutel:fix-cc-wrappers

Conversation

@fbeutel
Copy link

If I'm not mistaken, the changes made in pull request#197 break some rust build scripts.

The behavior as it originally was should have been correct, as it defines

CC="${WRAPPER_DIR}/cc-native-wrapper.sh"    # this is used when building on the host, as long as `HOST_CC` is not defined, and therefore it should point to cc-native-wrapper.shTARGET_CC="${WRAPPER_DIR}/cc-wrapper.sh"

According to theccdocs,TARGET_CC takes precedence overCC when cross-compiling to the target, and otherwiseCC is being used.

In addition, the original pull request defined the variableBUILD_CC, but that is meaningless for thecc crate (Yocto defines such avariable, butcc only looks forHOST_CC andCC when compiling for the host).

I think this should alsofix#204

I'm not sure what the original problem was which pull request#197 tried to solve, but maybe there was just no adequategcc installed on the host system?

taamrooz and tp-qomodo reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: Can no longer build libsqlite3-sys

1 participant

@fbeutel

[8]ページ先頭

©2009-2025 Movatter.jp