Commite0c1d27

authored

Merge pull request#11 from rush-db/fix/import_csv_data_argument_type

Fix csv_import data argument type

2 parentsfe913f4 +022d86b commite0c1d27Copy full SHA for e0c1d27

File tree

+11

-11

lines changed

+11

-11

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -644,7 +644,7 @@ Imports records from CSV data.`
`644`	`644`	`def import_csv(`
`645`	`645`	`self,`
`646`	`646`	`label:str,`
`647`		`-csv_data: Union[str,bytes],`
	`647`	`+data:str,`
`648`	`648`	`options: Optional[Dict[str,bool]]=None,`
`649`	`649`	`transaction: Optional[Transaction]=None`
`650`	`650`	`)-> List[Dict[str, Any]]`
`@@ -653,7 +653,7 @@ def import_csv(`
`653`	`653`	`Arguments:`
`654`	`654`
`655`	`655`	-`label` (str): Labelfor imported records
`656`		--`csv_data` (Union[str,bytes]):CSV data toimport
	`656`	+-`data` (Union[str,bytes]):CSV data toimport
`657`	`657`	-`options` (Optional[Dict[str,bool]]): Import options
`658`	`658`	-`transaction` (Optional[Transaction]): Optional transactionobject
`659`	`659`
`@@ -665,14 +665,14 @@ def import_csv(`
`665`	`665`
`666`	`666`	```python
`667`	`667`	`# Import records from CSV`
`668`		`-csv_data ="""name,age,department,role`
	`668`	`+data ="""name,age,department,role`
`669`	`669`	`John Doe,30,Engineering,Senior Engineer`
`670`	`670`	`Jane Smith,28,Product,Product Manager`
`671`	`671`	`Bob Wilson,35,Engineering,Tech Lead"""`
`672`	`672`
`673`	`673`	`records = db.records.import_csv(`
`674`	`674`	`label="EMPLOYEE",`
`675`		`-csv_data=csv_data,`
	`675`	`+data=data,`
`676`	`676`	`options={"returnResult":True,"suggestTypes":True}`
`677`	`677`	`)`
`678`	`678`	```

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`[tool.poetry]`
`2`	`2`	`name ="rushdb"`
`3`		`-version ="1.5.0"`
	`3`	`+version ="1.5.1"`
`4`	`4`	`description ="RushDB Python SDK"`
`5`	`5`	`authors = ["RushDB Team <hi@rushdb.com>"]`
`6`	`6`	`license ="Apache-2.0"`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -499,7 +499,7 @@ def find(`
`499`	`499`	`defimport_csv(`
`500`	`500`	`self,`
`501`	`501`	`label:str,`
`502`		`-csv_data:Union[str,bytes],`
	`502`	`+data:str,`
`503`	`503`	`options:Optional[Dict[str,bool]]=None,`
`504`	`504`	`transaction:Optional[Transaction]=None,`
`505`	`505`	`)->List[Dict[str,Any]]:`
`@@ -511,8 +511,8 @@ def import_csv(`
`511`	`511`
`512`	`512`	`Args:`
`513`	`513`	`label (str): The label/type to assign to all records created from the CSV.`
`514`		`-csv_data (Union[str, bytes]): The CSV content to import. Can be provided`
`515`		`- as a string or bytes object.`
	`514`	`+data (Union[str, bytes]): The CSV content to import. Can be provided`
	`515`	`+ as a string.`
`516`	`516`	`options (Optional[Dict[str, bool]], optional): Configuration options for the import operation.`
`517`	`517`	`Available options:`
`518`	`518`	`- returnResult (bool): Whether to return the created records data. Defaults to True.`
`@@ -541,7 +541,7 @@ def import_csv(`
`541`	`541`
`542`	`542`	`payload= {`
`543`	`543`	`"label":label,`
`544`		`-"data":csv_data,`
	`544`	`+"data":data,`
`545`	`545`	`"options":optionsor {"returnResult":True,"suggestTypes":True},`
`546`	`546`	`}`
`547`	`547`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -200,12 +200,12 @@ def test_transaction_rollback(self):`
`200`	`200`
`201`	`201`	`deftest_import_csv(self):`
`202`	`202`	`"""Test importing data from CSV"""`
`203`		`-csv_data="""name,age,department,role,salary`
	`203`	`+data="""name,age,department,role,salary`
`204`	`204`	`John Doe,30,Engineering,Senior Engineer,120000`
`205`	`205`	`Jane Smith,28,Product,Product Manager,110000`
`206`	`206`	`Bob Wilson,35,Engineering,Tech Lead,140000"""`
`207`	`207`
`208`		`-self.client.records.import_csv("EMPLOYEE",csv_data)`
	`208`	`+self.client.records.import_csv("EMPLOYEE",data)`
`209`	`209`
`210`	`210`	`deftest_search_result_integration(self):`
`211`	`211`	`"""Test SearchResult integration with find operations"""`

Comments

(0)