Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove Rails LTS versions#847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

NiklasHae
Copy link
Contributor

We (the Rails LTS team) noticed that some CVEs are marked as fixed by Rails LTS in the ruby-advisory-db. While we appreciate and are grateful for the effort, we would prefer not to list our commercial versions in the official database as fixed versions.

Currently, we do not have the capacity to actively monitor all versions listed in the ruby-advisory-db, verify their accuracy, and ensure correctness. Additionally, some fixes require extra context or additional information that may not be adequately reflected in the database. Most Rails LTS versions are a commercial offering, and we maintain a comprehensive list of all CVEs we have addressed—along with the necessary details—athttps://makandracards.com/railslts/474590-list-cves-addressed-rails-lts. Every Rails LTS customer also receives a newsletter with updates and additional information for all patches.

We would prefer to keep our own documentation as the single source of truth for Rails LTS related fixes. Thank you for your understanding.

Please checkhttps://makandracards.com/railslts/474590-list-cves-addressed-rails-lts for all CVEs addressed by Rails LTS and detailed information.
@postmodern
Copy link
Member

First, I will need some kind of confirmation that this is indeed Niklas Häusele speaking on behalf of Rails LTS / Makandra, and not some random GitHub account possibly posing as Niklas Häusele.

Second, the Rails LTS patched versions were added by PR#538. If we remove the Rails LTS specific patched versions, thenbundle-audit will flag those Rails LTS versions as vulnerable even though they've had patches backported to them. The user would then need to create or update their.bunder-audit.yml file and add CVEs to it as ignored. We should probably make a note of this in the README.

NiklasHae reacted with thumbs up emoji

Copy link
Member

@postmodernpostmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but also needs a note added to the README instructing Rails LTS users to check the official Rails LTS CVE list, and to add those CVEs to their.bundler-audit.yml file underignore:.

@jasnow
Copy link
Contributor

Monitoring PR and will make changes to my GHSA SYNC scripts after the merge.

@NiklasHae
Copy link
ContributorAuthor

NiklasHae commentedFeb 17, 2025
edited
Loading

Thank you@postmodern for taking a look.

I sent you an email to your linked GitHub profile address regarding verification. I'll update the PR accordingly 👍

@postmodernpostmodern merged commit05ea8d8 intorubysec:masterFeb 17, 2025
1 check passed
@postmodern
Copy link
Member

Added a note to the README ineb74560.

NiklasHae reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@postmodernpostmodernpostmodern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@NiklasHae@postmodern@jasnow

[8]ページ先頭

©2009-2025 Movatter.jp