Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork59
Assoc uses Identity formatter if any value is nil#450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bradleybuda wants to merge1 commit intoruby-syntax-tree:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Assoc uses Identity formatter if any value is nil#450
bradleybuda wants to merge1 commit intoruby-syntax-tree:mainfrombradleybuda:bare-assoc-hash-with-ruby-3.1-keyword
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The existing assoc formatter has logic to identify the case where avalue is nil (in a Ruby-3.1 style hash) and preserve the existingformatting. For example: `{ first:, "second" => "value" }` is correctlyleft as-is.However, this logic only worked if the first assoc in thecontainer had the nil value - if a later assoc had a nil value, theIdentity formatter might not be chosen which could cause the formatterto generate invalid Ruby code.As an example, this code: `{ "first" => "value", second: }` would beturned into `{ "first" => "value", :second => }`.This patch pulls the nil value check up to the top of`HashKeyFormatter.for` to ensure it takes precendence over any otherformatting selections. The fixtures have been updated to cover bothcases (nil value in first position, nil value in last position).Fixesruby-syntax-tree#4466e6feaf toc5b61fbCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing assoc formatter has logic to identify the case where a value is nil (in a Ruby-3.1 style hash) and preserve the existing formatting. For example:
{ first:, "second" => "value" }is correctly left as-is.However, this logic only worked if the first assoc in the container had the nil value - if a later assoc had a nil value, the Identity formatter might not be chosen which could cause the formatter to generate invalid Ruby code.
As an example, this code:
{ "first" => "value", second: }would be turned into{ "first" => "value", :second => }.This patch pulls the nil value check up to the top of
HashKeyFormatter.forto ensure it takes precendence over any other formatting selections. The fixtures have been updated to cover both cases (nil value in first position, nil value in last position).Fixes#446