Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork59
Plugin to remove spaces in hash#360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ryanb wants to merge1 commit intoruby-syntax-tree:mainChoose a base branch fromryanb:compact-hash-plugin
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
218904d
tob79d921
Comparedde31da
to61f2fe4
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This adds a plugin called
strip_hash
which removes spaces at the beginning and end of hash literals. For example, instead of{ foo: "bar" }
it generates{foo: "bar"}
. This helps distinguish hashes from blocks and brings it more in-line withstandard formatter. It is also similar to the deafult Prettier formatting for JS objects.I understand if you want to keep the built-in plugins to a minimum. I'm just not sure how to accomplish this with an external plugin without monkey patching which is brittle.
Whatever the case, feel free to rename this, or reject it if it's not in line with the project.
Update: I renamed this from
compact_hash
tostrip_hash
to parallelString#strip
method.