- Notifications
You must be signed in to change notification settings - Fork530
Add --all flag to fetch method#579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add --all flag to fetch method#579
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0340550 to33cf510CompareThe fix forCVE-2022-25648 broke a workflow for us by removing the abilityto fetch all remotes.This adds --all to the list of available flags for the #fetch method. It doesnot add :a as an alternative flag, as git fetch -a and git fetch --all arenot the same thing.Signed-off-by: Matthew Riedel <matthew.riedel@fluxfederation.com>
33cf510 to13ac421Comparejcouball commentedMay 18, 2022
@matthewriedel-flux thank you for reporting this issue and submitting a fix for it. As I reviewed this PR, I was going to give feedback to add tests for the new --all options and permutations. However, I realized that there isn't a good example to point to in the body of tests that shows how to do this. As a response, I created PR#583 which incorporates your changes (with a tweak or two) AND adds tests to test that the command line is generated as expected for different permutations of the fetch command. I created Test::Unit::TestCase#assert_command_line which should simplify creation of test cases that only test that the command line is generated in a particular way for given Git::Base method. In these cases, the git command line isn't actually called. I am hoping this helps improve the tests and speeds up the test suite. I'd be interested in your feedback in that PR. |
jcouball commentedMay 21, 2022
Closing this in favor of PR#583 |
Uh oh!
There was an error while loading.Please reload this page.
The fix forCVE-2022-25648 broke a workflow for us by removing the ability
to fetch all remotes.
This adds --all to the list of available flags for the #fetch method. It does
not add
:aas an alternative flag, asgit fetch -aandgit fetch --allarenot the same thing.
Signed-off-by: Matthew Riedelmatthew.riedel@fluxfederation.com
Your checklist for this pull request
🚨Please review theguidelines for contributing to this repository.
Description
Please describe your pull request.