- Notifications
You must be signed in to change notification settings - Fork417
Use typed data APIs#1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Use typed data APIs#1096
Conversation
eregon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
I tried to migrate it earlier today but this is really old code and got lost in trying to modernize it and gave up.
978eed6 intoruby-concurrency:masterUh oh!
There was an error while loading.Please reload this page.
| #include<atomic.h> | ||
| #endif | ||
| #if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__)&&__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ >=101200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we can change this to a check for C11 atomics since that's what this is using.
Not sure what's a good way to test that though.
Maybehave_header 'stdatomic.h'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably.
Untyped data APIs are deprecated.