Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/rubyPublic

ZJIT: Run against all tests#13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
st0012 wants to merge3 commits intoruby:master
base:master
Choose a base branch
Loading
fromShopify:zjit-expand-test-coverage

Conversation

st0012
Copy link
Member

@st0012st0012 commentedJul 18, 2025•
edited
Loading

  • make zjit-test-all now runs all test under/test, which includes several default gems' tests
  • Some additional exclusions have been added to/test/.excludes-zjit/
  • Since nowzjit-test-all takes quite a while, I think we can runzjit-check instead ofzjit-test on CI to get a faster feedback, even thotest_zjit.rb will be run twice (another time inzjit-test-all)

alexcameron89 reacted with hooray emojialexcameron89 reacted with heart emoji
@st0012st0012force-pushed thezjit-expand-test-coverage branch from38349cf to39a02bfCompareJuly 18, 2025 16:17
@st0012st0012force-pushed thezjit-expand-test-coverage branch fromde1124a toa056a5aCompareJuly 18, 2025 17:07
@st0012st0012 changed the titleZJIT: Test against all tests under/testZJIT: Run against all testsJul 18, 2025
@st0012st0012force-pushed thezjit-expand-test-coverage branch froma056a5a to5fb6475CompareJuly 18, 2025 17:18
@st0012st0012 marked this pull request as ready for reviewJuly 18, 2025 17:28
@matzbotmatzbot requested a review froma teamJuly 18, 2025 17:28
@tekknolagi
Copy link
Contributor

Can you explain the YAML changes please? I'm not sure the current description clears it up for me. There are too many suites and commands for me to keep track of.

@st0012
Copy link
MemberAuthor

st0012 commentedJul 18, 2025•
edited
Loading

zjit-test runs ZJIT's Rust tests.zjit-check runs both the Rust tests andtest_zjit.rb.
So currently we have one job running ZJIT Rust tests, and letzjit-test-all run all Ruby tests, includingtest_zjit.rb.
After the change, one job will run both ZJIT Rust tests andtest_zjit.rb, andzjit-test-all would still runtest_zjit.rb but I think that's fine.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@st0012@tekknolagi
[8]ページ先頭
©2009-2025 Movatter.jp