- Notifications
You must be signed in to change notification settings - Fork5.4k
Makerclass_ext->const_tbl a managed object#13807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
casperisfine wants to merge6 commits intoruby:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+260 −192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b3689b6 to202bebcCompare This comment has been minimized.
This comment has been minimized.
e420f5a to23493ceCompareHum, that's a good catch. Thank you. |
e90e3df toeaf45a1CompareRef:ruby/debug#1151 |
Similar to `managed_id_table`, but the values are marked.This can be used to implement RCU pattern on id tablesthat contain marked objects (e.g. `class->const_tbl`).
eaf45a1 to94e1d88CompareThe table itself is a `rb_id_marked_table` and the valuesare `IMEMO/constentry`.This open the door to do RCU updates of constant tables.
94e1d88 to5f6cdc9Compare5f6cdc9 to22019c9Compare
It did indeed fix one issue. Unfortunately the This also is unrelated to the write barrier issue :/. It's progress though. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table itself is a
rb_id_marked_tableand the values areIMEMO/constentry.This open the door to do RCU updates of constant tables.