Breaking control flow is almost certainly the most significant thing that is going on in that line of code, and so it deserves the most prominent spot, at the beginning of the line.

Hiding away control flow in the middle of a long line makes it unnecessarily hard to parse, and Ruby gives us a slew of forms in which we can rewrite the line with the change in flow emphasized.

Add rule stating control flow keywords should begin their line

f597c89

Drenmi mentioned this pull request

Dec 31, 2019

Add new Style/NonLocalControlFlowInTernary coprubocop/rubocop#7406

Closed

8 tasks

Drenmi changed the title~~Add rule stating control flow keywords should begin their line~~Control flow keywords should begin their line

Dec 31, 2019

Copy link

Member

koic commentedDec 31, 2019

The following idioms exist forreturn and raise in Ruby.

do_something and return
do_something || raise

For example, Rails framework will show users an error message using this idiom.

"redirect_to(...) and return\"

https://github.com/rails/rails/blob/v6.0.2.1/actionpack/lib/abstract_controller/rendering.rb#L10

So I think these cases need to be accepted.

Copy link

Collaborator

bbatsov commentedFeb 27, 2020

Agreed. I guess we can word this better and provide more examples.

Copy link

ContributorAuthor

Drenmi commentedMar 13, 2020

Hm. I would add a note about its usage in Rails, but I would be hesitant to recommend it in the style guide. It being used in the wild I think should not be seen as an indication that it's good. 😬

I would further argueand return is a Rails idiom, not a Ruby one. (At least I've only ever seen it in Rails codebases.) It is generally also not needed. I've worked with Rails full time for the past 6 years, and never writtenand return. 🙂

Will update the PR with the rationale for this rule, as well as notes on the usage ofand return.