rubocop/ruby-style-guidePublic

NotificationsYou must be signed in to change notification settings
Fork3.4k
Star16.5k

Use StandardError over Exception#775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

denys281 wants to merge1 commit intorubocop:master

base:master

Choose a base branch

fromdenys281:raise-exception

Open

Use StandardError over Exception#775

denys281 wants to merge1 commit intorubocop:masterfromdenys281:raise-exception

Conversation

Copy link

denys281 commentedSep 16, 2019

Based on discussion:https://github.com/rubocop-hq/rubocop/pull/7325/files#r320964544

Rubocop issue:rubocop/rubocop#7299

Use StandartError over Exception

cf1f898

denys281 mentioned this pull request

Sep 16, 2019

[Fix #7299] Implement Lint/RaiseException coprubocop/rubocop#7325

Merged

8 tasks

bquorning changed the title~~Use StandartError over Exception~~Use StandardError over Exception

Nov 12, 2019

bquorning reviewed

Nov 12, 2019

View reviewed changes

README.adoc

		@@ -1931,6 +1931,19 @@ end

		Prefer the use of exceptions from the standard library over introducing new exception classes.

		=== Do not `raise` `Exception` [[raise-exception]]

		Use `StandardError` over `Exception`.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps this section should include a sentence aboutwhy one should notraise Exception.

Copy link

Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you help with wording?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@denys281 Would "[Exception] will bypass test frameworks and error reporters" do?

Copy link

Author

denys281 commentedAug 11, 2020

@marcandre Could you take a look? Cop w merged some time ago.

Copy link

Contributor

marcandre commentedAug 11, 2020

This PR still needs work...
It's true one should not raise anException, but it is not true one should raise aStandardException; it's more an abstract base class than anything else.
One should raise the appropriate exception (e.g.TypeError) or if nothing fits, aRuntimeError (which shouldn't be specified).
Maybe it would be best to modify the "don't rescueException" section, as they are related... Don't raise one because you should not rescue those...