Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.4k
#359 - No Hanging Indentation#725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Based off of a very old issue that had a lot of interesting discussion:rubocop#359The idea here is that hanging indentation is incredibly hard to read while going down a page, and also incurs extra editing whenever more methods are added to a chain.
| ```ruby | ||
| # bad (hanging indent) | ||
| some_method.with.a_longer.chain(:parameter_1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this needs to be made clear with respect to:
- no method chain - e.g. some_method(a,
- short method chain - frankly it seems to the example you deleted looks fine, as it's not really a long method chain.
| @@ -643,6 +635,40 @@ Translations of the guide are available in the following languages: | |||
| end | |||
| ``` | |||
| * <a name="no-hanging-indent"></a> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybeno-hanging-param-indent or something like this?
Based off of a very old issue that had a lot of interesting discussion:
#359
The idea here is that hanging indentation is incredibly hard to read while going down a page, and also incurs extra editing whenever more methods are added to a chain.