Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.4k
Open
Description
Following myPR introducing a cop for numbered parameters,@koicsuggested that choosing the default style required a discussion in the style guide.
As a basis, here is what we agreed upon in our team. "Explicit" array name is not per se enforcable with a cop, so I'm not sure how it would fit in the guide.
# bad - non explicit array nameresults = electric_appliance.process!results.each { _1.taste }# bad - multi line blockwaffles.each do topping = @user.toppings.max_by(&:evaluation) _1.spread toppingend# bad - block can be created from methodwaffles.each { _1.taste } # => waffles.each(&:taste)waffles.each { taste(_1) } # => waffles.each(&method(:taste))# good - explicit array name + single line block + necessity to write blockwaffles.each { _1.spread(jam) }waffles.filter { _1.baking == :well_done }Metadata
Metadata
Assignees
Labels
No labels