Commitf7b8863

mita

authored and

torvalds

committed

fs/libfs.c: fix simple_attr_write() on 32bit machines

Assume that /sys/kernel/debug/dummy64 is debugfs file created bydebugfs_create_x64().# cd /sys/kernel/debug# echo 0x1234567812345678 > dummy64# cat dummy640x0000000012345678# echo 0x80000000 > dummy64# cat dummy640xffffffff80000000A value larger than INT_MAX cannot be written to the debugfs file createdby debugfs_create_u64 or debugfs_create_x64 on 32bit machine. Becausesimple_attr_write() uses simple_strtol() for the conversion.To fix this, use simple_strtoll() instead.Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>Cc: Greg Kroah-Hartman <gregkh@suse.de>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parente501f29 commitf7b8863Copy full SHA for f7b8863

File tree

1 file changed

-1

lines changed

fs
- libfs.c

1 file changed

-1

lines changed

`‎fs/libfs.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -822,7 +822,7 @@ ssize_t simple_attr_write(struct file file, const char __user buf,`
`822`	`822`	`gotoout;`
`823`	`823`
`824`	`824`	`attr->set_buf[size]='\0';`
`825`		`-val=simple_strtol(attr->set_buf,NULL,0);`
	`825`	`+val=simple_strtoll(attr->set_buf,NULL,0);`
`826`	`826`	`ret=attr->set(attr->data,val);`
`827`	`827`	`if (ret==0)`
`828`	`828`	`ret=len;/* on success, claim we got the whole input */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf7b8863

File tree

1 file changed

1 file changed

`‎fs/libfs.c‎`

0 commit comments