NotificationsYou must be signed in to change notification settings
Fork0
Star2

Commite2782f5

committed

Revert "dm raid: remove unnecessary discard limits for raid10"

This reverts commitf0e90b6.Matthew Ruffell reported data corruption in raid10 due to the changesin discard handling [1]. Revert these changes before we find a proper fix.[1]https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/Cc: Matthew Ruffell <matthew.ruffell@canonical.com>Cc: Xiao Ni <xni@redhat.com>Cc: Mike Snitzer <snitzer@redhat.com>Acked-by: Mike Snitzer <snitzer@redhat.com>Signed-off-by: Song Liu <songliubraving@fb.com>

1 parent7e7986f commite2782f5Copy full SHA for e2782f5

File tree

1 file changed

+11

-0

lines changed

drivers/md
- dm-raid.c

1 file changed

+11

-0

lines changed

`‎drivers/md/dm-raid.c‎`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3728,6 +3728,17 @@ static void raid_io_hints(struct dm_target ti, struct queue_limits limits)`
`3728`	`3728`
`3729`	`3729`	`blk_limits_io_min(limits,chunk_size_bytes);`
`3730`	`3730`	`blk_limits_io_opt(limits,chunk_size_bytes*mddev_data_stripes(rs));`
	`3731`	`+`
	`3732`	`+/*`
	`3733`	`+ * RAID10 personality requires bio splitting,`
	`3734`	`+ * RAID0/1/4/5/6 don't and process large discard bios properly.`
	`3735`	`+ */`
	`3736`	`+if (rs_is_raid10(rs)) {`
	`3737`	`+limits->discard_granularity=max(chunk_size_bytes,`
	`3738`	`+limits->discard_granularity);`
	`3739`	`+limits->max_discard_sectors=min_not_zero(rs->md.chunk_sectors,`
	`3740`	`+limits->max_discard_sectors);`
	`3741`	`+}`
`3731`	`3742`	`}`
`3732`	`3743`
`3733`	`3744`	`staticvoidraid_postsuspend(structdm_target*ti)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite2782f5

File tree

1 file changed

1 file changed

`‎drivers/md/dm-raid.c‎`

0 commit comments