forked fromtorvalds/linux
- Notifications
You must be signed in to change notification settings - Fork0
Commita9903f0
Matthias Kaehlcke
Ingo Molnar
sched/sysctl: Fix attributes of some extern declarations
The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrateand sysctl_sched_time_avg includes the attribute const_debug. Thisattribute is not part of the extern declaration of these variables ininclude/linux/sched/sysctl.h, while it is in kernel/sched/sched.h,and as a result Clang generates warnings like this: kernel/sched/sched.h:1618:33: warning: section attribute is specified on redeclared variable [-Wsection] extern const_debug unsigned int sysctl_sched_time_avg; ^ ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here extern unsigned int sysctl_sched_time_avg;The header only declares the variables when CONFIG_SCHED_DEBUG is defined,therefore it is not necessary to duplicate the definition of const_debug.Instead we can use the attribute __read_mostly, which is the expansion ofconst_debug when CONFIG_SCHED_DEBUG=y is set.Signed-off-by: Matthias Kaehlcke <mka@chromium.org>Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>Cc: Douglas Anderson <dianders@chromium.org>Cc: Guenter Roeck <groeck@chromium.org>Cc: Linus Torvalds <torvalds@linux-foundation.org>Cc: Peter Zijlstra <peterz@infradead.org>Cc: Shile Zhang <shile.zhang@nokia.com>Cc: Thomas Gleixner <tglx@linutronix.de>Link:http://lkml.kernel.org/r/20171030180816.170850-1-mka@chromium.orgSigned-off-by: Ingo Molnar <mingo@kernel.org>1 parentb0d40d2 commita9903f0
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments
Comments
(0)