Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit4da3a54

Browse files
andrea-parrimartinkpetersen
authored andcommitted
Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()"
This reverts commit3b8c72d.Dexuan reported a regression where StorVSC fails to probe a device (andwhere, consequently, the VM may fail to boot). The root-cause analysis ledto a long-standing race condition that is exposed by the validation /commitin question. Let's put the new validation aside until a proper solutionfor that race condition is in place.Link:https://lore.kernel.org/r/20201211131404.21359-1-parri.andrea@gmail.comFixes:3b8c72d ("scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()")Cc: Dexuan Cui <decui@microsoft.com>Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>Cc: "Martin K. Petersen" <martin.petersen@oracle.com>Cc: linux-scsi@vger.kernel.orgSigned-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent359db63 commit4da3a54

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

‎drivers/scsi/storvsc_drv.c‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,11 +1246,6 @@ static void storvsc_on_channel_callback(void *context)
12461246
request= (structstorvsc_cmd_request*)
12471247
((unsigned long)desc->trans_id);
12481248

1249-
if (hv_pkt_datalen(desc)<sizeof(structvstor_packet)-vmscsi_size_delta) {
1250-
dev_err(&device->device,"Invalid packet len\n");
1251-
continue;
1252-
}
1253-
12541249
if (request==&stor_device->init_request||
12551250
request==&stor_device->reset_request) {
12561251
memcpy(&request->vstor_packet,packet,

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp