Commit1e1132e

Mikulas Patocka

authored and

snitm

committed

dm writecache: fix a crash due to reading past end of dirty_bitmap

wc->dirty_bitmap_size is in bytes so must multiply it by 8, not byBITS_PER_LONG, to get number of bitmap_bits.Fixes crash in find_next_bit() that was reported:https://bugzilla.kernel.org/show_bug.cgi?id=200819Reported-by: edo.rus@gmail.comFixes:48debaf ("dm: add writecache target")Cc: stable@vger.kernel.org # 4.18Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>Signed-off-by: Mike Snitzer <snitzer@redhat.com>

1 parentbc9e9cf commit1e1132eCopy full SHA for 1e1132e

File tree

1 file changed

-1

lines changed

drivers/md
- dm-writecache.c

1 file changed

-1

lines changed

`‎drivers/md/dm-writecache.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ static void ssd_commit_flushed(struct dm_writecache *wc)`
`457`	`457`	`COMPLETION_INITIALIZER_ONSTACK(endio.c),`
`458`	`458`	`ATOMIC_INIT(1),`
`459`	`459`	`};`
`460`		`-unsignedbitmap_bits=wc->dirty_bitmap_size*BITS_PER_LONG;`
	`460`	`+unsignedbitmap_bits=wc->dirty_bitmap_size*8;`
`461`	`461`	`unsignedi=0;`
`462`	`462`
`463`	`463`	`while (1) {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1e1132e

File tree

1 file changed

1 file changed

`‎drivers/md/dm-writecache.c‎`

0 commit comments