NotificationsYou must be signed in to change notification settings
Fork524
Star1.5k

Add template for the MNRAS (Monthly Notices of the Royal Astronomical Society) article.#175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

yihui merged 11 commits intorstudio:masterfromoleskiewicz:master

Jul 5, 2018

Merged

Add template for the MNRAS (Monthly Notices of the Royal Astronomical Society) article.#175

yihui merged 11 commits intorstudio:masterfromoleskiewicz:master

Jul 5, 2018

Conversation

Copy link

Contributor

oleskiewicz commentedJun 21, 2018•
edited
Loading

This creates a template for a submission to MNRAS journal, based on their LaTeX template file. I've added most of the housekeeping as outlinedhere, but wasn't sure what more is there to be done.

oleskiewicz mentioned this pull request

Jun 21, 2018

Feature Request: Support in Rticles for Using Additional Journals, such as Biometrics#125

Closed

jjallaire reviewed

Jun 22, 2018

View reviewed changes

R/mnras_article.R Outdated

		md_extensions = md_extensions,
		format = "mnras_article",
		template = "template.tex",
		csl = "mnras.csl")

Copy link

Member

jjallaireJun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to usesystem.file() to refer to these (as the current code assumes they are in the current working directory)

Copy link

ContributorAuthor

oleskiewicz commentedJun 22, 2018

Thanks@jjallaire, I'm just starting learning R so this is all a bit new to me!

I have changed thetemplate andcsl references using thefind_resource helper function, just asplos_articledoes it, I hope this is better now?

Copy link

Member

jjallaire commentedJun 22, 2018

You should also run the tests locally (you can do this withdevtools::test()). When I run your test I get this failure:

unused argument (csl="/Users/jjallaire/packages/rticles/inst/rmarkdown/templates/mnras_article/resources/mnras.csl")1:rmarkdown::render(testdoc)at/Users/jjallaire/packages/rticles/tests/testthat/test_formats.R:302: create_output_format(output_format$name,output_format$options)3: do.call(output_format_func,options)

I think you want to callpdf_document_format() rather thanpdf_document()

Copy link

Member

jjallaire commentedJun 22, 2018

I am still unable to get this article format to actually work. Here is the error I get:

processingfile:Untitled.Rmdoutputfile:Untitled.knit.mdtlmgrsearch--file--global'/example'!LaTeXError:File `example' not found.Error: Failed to compile Untitled.tex. See Untitled.log for more info.In addition: Warning message:In parse_packages(logfile, quiet = c(TRUE, FALSE, FALSE)) :  Failed to find a package that contains exampleExecution halted

Copy link

ContributorAuthor

oleskiewicz commentedJun 22, 2018•
edited
Loading

Oh I see -- it seems like the LaTeX environment is trying to pick up the example figure (example.png), but it assumes the.tex extension and fails due to some relative path.

I'll change the way figure is rendered in the skeleton (it's my understanding that including figures throughknitr is preferred anyway?), hopefully this will fix it.

Sorry it keeps failing, the test has passed successfully for me.

yihui requested changes

Jul 3, 2018

View reviewed changes

Copy link

Contributor

yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please rebase against the current master branch here, resolve conflicts, and force push. Then your format will be automatically check on Travis. Thanks!

yihui force-pushed themaster branch 3 times, most recently from8023cbf to928d6cdCompare

July 3, 2018 16:11

Piotr Oleskiewicz added9 commits

July 4, 2018 14:32

Add MNRAS templates and skeleton.

c4feaa9

Add a CSL file.

e62e17b

I couldn't find official MNRAS CSL file so just this one for now.

Add combinations of authors and affiliations

43129d1

Add MNRAS entry to NAMESPACE and README.md

0fc5a28

Add test for MNRAS template

22e3778

Reference template files paths

1f84a39

Change PDF function to include CSL in Pandoc

8a09123

inherit_pdf_document was changed to pdf_document_format

Fix missing figure extensions

54651ba

LaTeX in the testing environment appears to be looking for .tex figurebefore finding the .png one.

Add appendices

e281eca

Appendices need to be positioned below references, hence the slightlyhacky div positioning.  See:https://stackoverflow.com/q/16427637

Copy link

ContributorAuthor

oleskiewicz commentedJul 4, 2018

The build fails for the same reason as previously:

Package pdftex.def Error: File `example.png' not found: using draft setting.

I have checked other templates, and for instanceamq_article passes the Travis build while including figures from external files in skeleton. Similarly, there are no issues with the template locally. How do I include theexample.png in the test render?

yihui requested changes

Jul 4, 2018

View reviewed changes

inst/rmarkdown/templates/mnras_article/skeleton/skeleton.Rmd Outdated

		% To include a figure from a file named example.*
		% Allowable file formats are eps or ps if compiling using latex
		% or pdf, png, jpg if compiling using pdflatex
		\includegraphics[width=\columnwidth]{example.png}