- Notifications
You must be signed in to change notification settings - Fork87
Support websocket compression (permessage-deflate)#377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This implements server_no_context_takeover and client_no_context_takeoversupport, but in a pretty naive way for now that gives correct results but doesn’t provide anymemory efficiency advantage, which is the whole point of this feature.
e950415 to058f75bCompare058f75b to1762ce7Comparezeehio commentedOct 25, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
On shiny websites with plotly plots with a large number of points, generating the plot is the first bottleneck. Once that is cached (bindCache...) the transfer of the plotly object from server to client becomes the bottleneck. Having websocket per-message compression would reduce the cost of the transfer at the expense of compressing/decompressing each message. Ideally, having some websocket-based caching system would be awesome, so the web browser does not download the same plot more than once. I would imagine httpuv sending a hash of the response first, and then, if the browser does not have anything matching that hash, the full response (maybe with compression as implemented here). Thanks for all this work anyway... It's easy to suggest features, but it is much harder to implement them! |
anthonynorth commentedJan 31, 2024
Looking for permessage-deflate support in shiny led me here. Are there plans to merge this into main? |
TBlackmore commentedJul 4, 2024
Also came here looking to speed up shiny messages. Can I upvote this feature? |
No description provided.