Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes for older macOS#348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
barracuda156 wants to merge2 commits intorstudio:main
base:main
Choose a base branch
Loading
frombarracuda156:darwin

Conversation

@barracuda156
Copy link

This PR is based on patches used in Macports for buildinglibuv:https://github.com/macports/macports-ports/tree/master/devel/libuv/files

P. S. I am bringing R packages into Macports now, andhttpuv among them, and we want everything to build on Leopard up; it is desirable to have it fixed with upstream rather than keep carrying our local patch.

@CLAassistant
Copy link

CLAassistant commentedDec 13, 2022
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@wch
Copy link
Collaborator

wch commentedDec 13, 2022

What versions of MacOS does this provide support for? The highest version I see reference to in this PR isMAC_OS_X_VERSION_MAX_ALLOWED >= 1070, and I believe that's for OS X 10.7, which last had a release 10 years ago.

It would be preferable if you could get the changes into libuv. We periodically update the copy of libuv bundled with httpuv, and it wouldn't be a good use of our time to be maintaining libuv patches for these old OS versions.

@barracuda156
Copy link
Author

@wch As for OS X versions, everything from 10.4.11 up is still used, and specifically 10.5.8 is used quite a bit, since that is the last official release supporting PPC.
However I agree, that if you just borrow the code fromlibuv, then you face the same problem as we do with carrying patches – and it won’t be a Pareto improvement :)

I will try to find out what happened with submission of those tolibuv upstream. If no one tried for w/e reason, I can try that.

@barracuda156
Copy link
Author

@ryandesign Ryan, may I ask if you know whether our patches tolibuv were submitted to upstream? Or should I try that?
At least twoR packages are broken without those, and understandably it is preferable to havelibuv itself fixed rather than carrying patches, if that works.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barracuda156@CLAassistant@wch

[8]ページ先頭

©2009-2025 Movatter.jp