- Notifications
You must be signed in to change notification settings - Fork218
IR Generation#820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
rich-iannone wants to merge72 commits intomasterChoose a base branch fromir-generation
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
IR Generation#820
Changes from1 commit
Commits
Show all changes
72 commits Select commitHold shift + click to select a range
09864e4 Create ir_example.html
rich-iannone8b70ae2 Create render_ir.R
rich-iannone3aabf9b Update DESCRIPTION
rich-iannoneeca725c Update render_ir.R
rich-iannone39a3ab0 Update render_ir.R
rich-iannonef55df8d Add the `create_col_group_ir()` util fn
rich-iannone625c362 Update ir_example.html
rich-iannoneb202bc0 Update render_ir.R
rich-iannoneb1e7127 Put `colgroup_element` in a tagList
rich-iannone583e9d5 Add the `create_heading_ir()` function
rich-iannoned0ee0ff Add the `create_columns_ir()` function
rich-iannonec6b3213 Update ir_example.html
rich-iannonee3ebd60 Modify tag names
rich-iannone003ae5a Return empty tagList is columns are hidden
rich-iannone6d6db29 Modify tag names for column labels loc
rich-iannoneeacff8e Add the `create_body_ir()` function
rich-iannone66c7d41 Remove TODO note
rich-iannone5354f30 Update ir_example.html
rich-iannone929d673 Update ir_example.html
rich-iannone2b5d74c Update utils_render_ir.R
rich-iannone03c6a66 Update ir_example.html
rich-iannone51d77fc Add `combine_as_ir()` util fn
rich-iannonec31bd26 Ensure that stub role is set for summary rows
rich-iannone8a60c75 Revise `create_heading_ir()`
rich-iannone22cf163 Update utils_render_ir.R
rich-iannone01bf3ea Update render_ir.R
rich-iannonebbc9eaa Add `stub` role in more elements
rich-iannoneb29ad3c Reformat footnotes in IR
rich-iannone889e3a5 Generate the `table_defs` object
rich-iannone97a9abb Add the `config` element to the IR
rich-iannonefdf92af Remove unneeded stmts
rich-iannone8c4a540 Implement styles in spanner elements
rich-iannonea09040d Implement styling for column labels
rich-iannone4ac52a3 Implement styling for stubhead label
rich-iannone662e092 Update ir_example.html
rich-iannone0d0d5f5 Implement styling in footnotes location
rich-iannonee19018b Add `data` arg to `combine_as_ir()`
rich-iannone0217e4f Update render_ir.R
rich-iannone9df9f93 Rewrite implementation of config element
rich-iannoned97eab7 Remove stmt that returns an empty tagList
rich-iannoneb67a58d Refactor `combine_as_ir()`
rich-iannone9666427 Return IR as a character vector
rich-iannone523c067 Apply role as needed to stub cells
rich-iannone3d040b7 Move position of `role` attr for summary rows
rich-iannonefe0ea6c Render all config keys in kebab case
rich-iannonee01472a Modify order of `option_names`
rich-iannonea478771 Create ir-generation.R
rich-iannonee9574a6 Use `mark` tag to enclose rendered footnote marks
rich-iannone9824c8c Use `mark` tag instead of `i` in footer area
rich-iannonee70ab27 Update ir-generation.R
rich-iannone630009c Merge branch 'master' into ir-generation
rich-iannone067d168 Add `footnote-id` attr to all <mark> elements
rich-iannone51132d4 Disable failing tests for HTML output
rich-iannone4d8f33a Update ir-generation.R
rich-iannoneccdf755 Update ir_example.html
rich-iannone4dfad82 Set `role` names in kebab case
rich-iannonee9fe61c Update utils_render_html.R
rich-iannone1553e45 Update utils_render_ir.R
rich-iannonefa84a20 Update utils_render_html.R
rich-iannonef4752f3 Update utils_render_ir.R
rich-iannone31748e8 Update ir-generation.R
rich-iannonefcf4209 Add closing tag for <config> element
rich-iannonef9558f1 Update ir-generation.R
rich-iannone86ddb1e Improve column counting routine
rich-iannonefc049d7 Update utils_render_ir.R
rich-iannone32dd92a Update ir-generation.R
rich-iannone6fa2999 Update utils_render_ir.R
rich-iannone3d686dd Update ir-generation.R
rich-iannoneb531976 Use `class` instead of `loc` attr name
rich-iannone326b59d Modify XPATH expression
rich-iannoneb791a0f Remove stmts that get table dims
rich-iannoneb0c1058 Simplify `combine_as_ir()`
rich-iannoneFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update ir-generation.R
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit4d8f33a6111fd304f7e14117cf9eb60b01715ba9
There are no files selected for viewing
2 changes: 1 addition & 1 deletionscripts/ir-generation.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -50,4 +50,4 @@ exibble %>% | ||
| row.striping.include_stub = TRUE, | ||
| row.striping.include_table_body = TRUE | ||
| ) %>% | ||
| render_to_ir() | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.