- Notifications
You must be signed in to change notification settings - Fork218
Prefix ids with table#1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
arbelt wants to merge25 commits intorstudio:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
25 commits Select commitHold shift + click to select a range
b235bc8 Merge pull request #1965 from rstudio/ci-remove-connect-deploy
rich-iannone349c59e initial add table_id
arbelta6a06e2 Add table_id parameter to render_row_data and update related functions
arbelt17e09e8 Refactor ID attributes to use valid_html_id with tbl_id for improved …
arbeltaddfce8 Refactor header construction in render_row_data for improved ID handl…
arbeltcb8309c Fix handling of current_group_id in render_row_data to support vector…
arbelt2ef58be Fix: Avoid re-applying valid_html_id to row_id_i for stub cells in re…
arbelta3a6935 Refactor header component construction in render_row_data to separate…
arbelte33199a Refactor header creation in render_row_data to handle group IDs and c…
arbeltc8d44fd Refactor render_row_data to improve group ID and row header ID handli…
arbelt03bd760 Refactor render_row_data to improve header assignment logic, enhancin…
arbeltb8e27e2 Enhance valid_html_id function to check for NA values in tbl_id, ensu…
arbeltd4b63ab Refactor create_body_component_h to correctly handle row ID generatio…
arbelt2a865c6 Refactor render_row_data to streamline group ID handling, ensuring ac…
arbelt28c59dd update testing functions to accommodate prefixed element ids
arbelt4bbb51d use c to add stub indent class instead of paste
arbelt834be43 update snapshot for tab_stub_indent after extra_classes fix
arbeltd989bd9 Merge branch 'master' into prefix-ids-with-table-id
arbeltcbbeb7a don't manipulate or prefix empty ids in 'valid_html_id`
arbelt86c21e7 more meaningful tests
arbeltb5a27ed fix test helper `remove_id_prefixes` and remove dep on stringr
arbelt6e68d24 remove stringr dep from table_id test
arbelt0c6617b Merge branch 'master' into prefix-ids-with-table-id
arbelt0e20650 Merge branch 'master' into prefix-ids-with-table-id
arbeltfd4847e Merge branch 'master' into prefix-ids-with-table-id
arbeltFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'master' into prefix-ids-with-table-id
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd989bd9644ebf0bd663d2357b34ba598608c3ff6
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.