Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/gtPublic

Prefix ids with table#1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
arbelt wants to merge25 commits intorstudio:master
base:master
Choose a base branch
Loading
fromarbelt:prefix-ids-with-table-id

Conversation

@arbelt
Copy link

Summary

Initial implementation of prefixing element ids with the table id. This doesn't totally solve for potential duplicate IDs within a page, but should at least remove one of the most common sources (multiple tables with same column names).

This is a pretty big codebase. Happy to try to package this up more nicely but might need some pointers if there are interactions I'm missing.

Related GitHub Issues and PRs

Checklist

@CLAassistant
Copy link

CLAassistant commentedMar 3, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@olivroy
Copy link
Collaborator

Thanks for the PR. I didn't really review, but if you want the CI to pass, you will have to run tests locally and accept snapshot changes. i.e. withtestthat::snapshot_accept() for us to see the direct implications of your changes.

Also, you have to change the expected digest value in test-as_raw_html.R` for tests to pass. This is normal when we change the html code of a table.

rich-iannoneand others added15 commitsMarch 5, 2025 11:05
… unprefixed and prefixed IDs, ensuring valid_html_id is only applied where necessary.
…olumn IDs individually, improving HTML compliance and clarity.
…g handling of group IDs and row boundaries for better HTML compliance.
…n for two-column stubs, improving HTML compliance and clarity.
…curate cell-specific group IDs for improved HTML compliance and clarity.
@arbeltarbeltforce-pushed theprefix-ids-with-table-id branch from8ddd2c2 to28c59ddCompareMarch 6, 2025 18:18
@arbelt
Copy link
Author

thanks! I've updated some of the testing code & accepted snapshots, so they should pass, but I didn't have a chance to reviewall the snapshot changes

@arbeltarbelt changed the titleWIP: Prefix ids with tablePrefix ids with tableMar 11, 2025
@arbelt
Copy link
Author

@olivroy I've scanned through the snapshot results and addressed any issues I saw, so I think it's about set — at least no todos pending on my list for now.

@arbelt
Copy link
Author

oops, should've run check. removed the test dependency on stringr, and also fixed the regex in the helper in the last commit

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arbelt@CLAassistant@olivroy@rich-iannone

[8]ページ先頭

©2009-2025 Movatter.jp