- Notifications
You must be signed in to change notification settings - Fork218
Prefix ids with table#1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedMar 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
olivroy commentedMar 4, 2025
Thanks for the PR. I didn't really review, but if you want the CI to pass, you will have to run tests locally and accept snapshot changes. i.e. with Also, you have to change the expected digest value in test-as_raw_html.R` for tests to pass. This is normal when we change the html code of a table. |
ci: remove Connect deployment
…ing and HTML compliance
… input and exclude NA values
… unprefixed and prefixed IDs, ensuring valid_html_id is only applied where necessary.
…olumn IDs individually, improving HTML compliance and clarity.
…ng, enhancing HTML compliance and clarity.
…g handling of group IDs and row boundaries for better HTML compliance.
…ring robust ID generation.
…n for two-column stubs, improving HTML compliance and clarity.
…curate cell-specific group IDs for improved HTML compliance and clarity.
8ddd2c2 to28c59ddComparearbelt commentedMar 6, 2025
thanks! I've updated some of the testing code & accepted snapshots, so they should pass, but I didn't have a chance to reviewall the snapshot changes |
- fixes issues with empty spanners being assigned ids that were often duplicated
arbelt commentedMar 11, 2025
@olivroy I've scanned through the snapshot results and addressed any issues I saw, so I think it's about set — at least no todos pending on my list for now. |
arbelt commentedMar 12, 2025
oops, should've run check. removed the test dependency on stringr, and also fixed the regex in the helper in the last commit |
Summary
Initial implementation of prefixing element ids with the table id. This doesn't totally solve for potential duplicate IDs within a page, but should at least remove one of the most common sources (multiple tables with same column names).
This is a pretty big codebase. Happy to try to package this up more nicely but might need some pointers if there are interactions I'm missing.
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.