Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: keep sync notifier state when a dependency changes#4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Yegair wants to merge1 commit intorrousselGit:master
base:master
Choose a base branch
Loading
fromYegair:fix/riverpod-4417

Conversation

@Yegair
Copy link

@YegairYegair commentedNov 26, 2025
edited
Loading

Related Issues

fixes#4417

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

  • I have updated theCHANGELOG.md of the relevant packages.
    Changelog files must be edited under the form:

    ##Unreleased fix/major/minor- Description of your change. (thanks to@yourGithubId)
  • If this contains new features or behavior changes,
    I have updated the documentation to match those changes.

@coderabbitai
Copy link
Contributor

coderabbitaibot commentedNov 26, 2025
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@rrousselGit
Copy link
Owner

Could you add a check verifying that after an invalidate wherestate == null, callingthis.state insidebuild doesn't throw?

I would expect that to fail with your current changes.

@Yegair
Copy link
Author

Not sure I understood that correctly, but did add a test that represents how I understood it.

The original implementation did cause that test to fail with an exception hinting at an uninitialized provider. With thehasValue: true check you proposed it does not throw an exception.

However, now aProviderObserver related test fails. Didn't really investigate it, but out of the box, I have no idea what might be the reason.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rrousselGitrrousselGitrrousselGit left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notifier is disposed when another Notifier it watches updates

2 participants

@Yegair@rrousselGit

[8]ページ先頭

©2009-2025 Movatter.jp