Commit86ccdfc

authored

Merge pull request#55 from allenbaron/fix_ftxt

Update empc_ftxt() to indicate 1 input limit

2 parentsb3d4794 +99fb4ba commit86ccdfcCopy full SHA for 86ccdfc

File tree

-7

lines changed

-7

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`		`-#' Fetch Europe PMC fulltexts`
	`1`	`+#' Fetch Europe PMC fulltext`
`2`	`2`	`#'`
`3`		`-#' This function loads fulltexts into R. Fulltexts are in XML format andare`
	`3`	`+#' This function loadsonefulltext into R. Fulltext is in XML format andis`
`4`	`4`	`#' only provided for the Open Access subset of Europe PMC.`
`5`	`5`	`#'`
`6`	`6`	`#' @param ext_id character, PMCID.`
`@@ -15,8 +15,8 @@`
`15`	`15`	`#' epmc_ftxt("PMC3639880")`
`16`	`16`	`#' }`
`17`	`17`	`epmc_ftxt<-function(ext_id=NULL) {`
`18`		`-if (!grepl("^PMC",ext_id))`
`19`		`- stop("Please providea PMCID, i.e.ids starting with 'PMC'")`
	`18`	`+if (!grepl("^PMC",ext_id)\|\| length(ext_id)!=1)`
	`19`	`+ stop("Please provideone PMCID, i.e.id starting with 'PMC'")`
`20`	`20`	`# call api`
`21`	`21`	`req<-`
`22`	`22`	`httr::RETRY("GET",`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,14 +5,14 @@ test_that("epmc_ftxt returns", {`
`5`	`5`	`a<- epmc_ftxt("PMC3257301")`
`6`	`6`	`b<- epmc_ftxt("PMC3639880")`
`7`	`7`
`8`		`-#correct class metadata`
	`8`	`+#correct class metadata`
`9`	`9`	`expect_is(a,"xml_document")`
`10`	`10`	`expect_is(b,"xml_document")`
`11`	`11`
`12`	`12`	`# fails correctly`
`13`	`13`	`expect_error(epmc_ftxt("2PMC3448176"))`
`14`	`14`	`expect_error(epmc_ftxt("PMC3476"))`
`15`	`15`	`expect_error(epmc_ftxt("3476"),`
`16`		`-"Please providea PMCID, i.e.ids starting with 'PMC'"`
`17`		`-)`
	`16`	`+"Please provideone PMCID, i.e.id starting with 'PMC'"`
	`17`	`+ )`
`18`	`18`	`})`

Comments

(0)