Reviewing files that changed from the base of the PR and betweenc496509 andfd63b7b.

• playbooks/robusta_playbooks/babysitter.py (1 hunks)
• playbooks/robusta_playbooks/event_enrichments.py (2 hunks)
• scripts/generate_kubernetes_code.py (4 hunks)
• src/robusta/core/discovery/top_service_resolver.py (3 hunks)
• src/robusta/core/playbooks/internal/discovery_events.py (3 hunks)
• src/robusta/core/reporting/base.py (4 hunks)
• src/robusta/core/reporting/consts.py (2 hunks)
• src/robusta/core/reporting/finding_subjects.py (3 hunks)
• src/robusta/core/reporting/findings.py (1 hunks)
• src/robusta/core/triggers/error_event_trigger.py (2 hunks)
• src/robusta/integrations/kubernetes/autogenerated/events.py (39 hunks)
• src/robusta/integrations/prometheus/models.py (2 hunks)

playbooks/robusta_playbooks/event_enrichments.py (2)

43-43:Import looks good.

TheFindingOwner import is properly used in the file.

---

76-76:Ownership enrichment implemented correctly.

TheFindingOwner is properly constructed from the event's owner references and passed to theFindingSubject. This enriches the finding with ownership metadata as intended.

src/robusta/core/reporting/findings.py (1)

1-10:Well-structured data model for ownership metadata.

TheFindingOwner class properly encapsulates Kubernetes ownership information with appropriate fields and types. The Pylint warning about too few public methods is a false positive for data models.

src/robusta/core/reporting/consts.py (1)

50-50:Consistent enum extension for replicaset support.

TheTYPE_REPLICASET enum value and correspondingfrom_kind method case are properly added together, maintaining consistency in the enum implementation.

Also applies to: 66-67

src/robusta/core/triggers/error_event_trigger.py (2)

5-5:Import properly used.

TheFindingOwner import is correctly utilized in the service key resolution logic.

---

74-77:Enhanced service key resolution with ownership context.

The changes correctly extract thekind and create aFindingOwner instance with owner references to provide richer context for service key resolution. This improvement aligns with the broader ownership metadata integration.

src/robusta/core/playbooks/internal/discovery_events.py (3)

19-19:LGTM: Import addition is consistent with the ownership enhancement.

The import ofFindingOwner aligns with the broader changes to integrate ownership metadata.

---

85-87:LGTM: Enhanced service key resolution with ownership context.

The addition ofkind andowner parameters toTopServiceResolver.guess_service_key provides better context for service resolution. The implementation correctly passes the owner from the finding's subject.

---

81-81: ```shell
#!/usr/bin/env bash

Locate the file defining FindingOwner and inspect its constructor for None handling

1. Find class declaration

rg --no-heading "class FindingOwner" -n .

2. If found, display the class definition andinit body

FILE=$(rg -l "class FindingOwner" . | head -n1)
if [[ -n "$FILE" ]]; then
echo "=== Definition in $FILE ==="
rg -n "class FindingOwner" -A 15 "$FILE"
echo
echo "===init in $FILE ==="
rg -n "definit" -A 10 "$FILE"
else
echo "FindingOwner class not found in the repository."
fi

</details><details><summary>src/robusta/core/reporting/base.py (3)</summary>`17-17`: **LGTM: Import addition supports ownership metadata integration.**The import of `FindingOwner` is correctly added to support the new ownership functionality.---`205-205`: **LGTM: Well-designed optional owner parameter.**The `owner` parameter is properly implemented as optional with correct type annotation, maintaining backward compatibility while enabling ownership metadata.Also applies to: 214-214---`257-259`: **LGTM: Enhanced service resolution with ownership context.**The `TopServiceResolver.guess_cached_resource` call now includes ownership information, providing better context for service resolution. The parameters are correctly passed from the subject's attributes.</details><details><summary>src/robusta/core/reporting/finding_subjects.py (2)</summary>`4-4`: **LGTM: Import addition enables ownership metadata support.**The import of `FindingOwner` is correctly added to support the new ownership functionality in finding subjects.---`27-27`: ```shell#!/bin/bash# Locate the FindingOwner class definition and inspect its __init__ for None handlingrg -n "class FindingOwner" -C 5

src/robusta/integrations/prometheus/models.py (3)

9-9:LGTM: Imports correctly added for ownership metadata support.

The imports ofOwnerReference andFindingOwner are properly added to support the enhanced ownership functionality.

Also applies to: 13-13

---

143-197:LGTM: Comprehensive ownership metadata extraction.

The implementation systematically extractsownerReferences from all supported Kubernetes resource types (deployment, daemonset, statefulset, node, pod, job, hpa) and correctly sets theunknown_owner flag when no specific resource type is matched. This provides comprehensive ownership context for Prometheus alerts.

---

202-203:LGTM: Enhanced FindingSubject with ownership information.

TheFindingSubject constructor now includes theowner parameter with properly constructedFindingOwner object, maintaining consistency with the broader ownership enhancement across the codebase.

scripts/generate_kubernetes_code.py (3)

80-80:LGTM: Import added to autogenerated code template.

The import ofFindingOwner is correctly added to the code generation template, ensuring it will be available in all autogenerated Kubernetes event classes.

---

181-190:LGTM: Consistent ownership metadata integration in autogenerated events.

The pattern of addingowner=FindingOwner(owner_references=self.obj.metadata.ownerReferences) is consistently applied across all autogenerated event classes (base KubernetesResourceEvent, specific resource events, and change events). This ensures uniform ownership metadata support across the entire Kubernetes event system.

Also applies to: 265-274, 289-298

---

189-189: ```shell
#!/bin/bash

Search for the FindingOwner class definition and inspect its constructor

rg "class FindingOwner" -A10 -n

</details><details><summary>src/robusta/core/discovery/top_service_resolver.py (3)</summary>`6-6`: **LGTM! Required imports properly added.**The imports are correctly added to support the new ownership-aware functionality.Also applies to: 10-11---`32-32`: **LGTM! Caching strategy for owner references.**Adding a cache for owner references is a good optimization to avoid repeated API calls.---`58-60`: **LGTM! Method signature properly updated.**The method signature correctly includes the new ownership parameters and passes them through to the updated guess_cached_resource method.</details></blockquote></details></details><!-- This is an auto-generated comment by CodeRabbit for review status -->