- Notifications
You must be signed in to change notification settings - Fork59
Test MJCF descriptions with Pinocchio#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
stephane-caron wants to merge13 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedAug 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Pull Request Test Coverage Report forBuild 19733273569Details
💛 -Coveralls |
9a77ff2 todfba0d6Compare561a935 tod482ef4CompareMemberAuthor
stephane-caron commentedMar 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have tested the following MJCF descriptions at my disposal with Pinocchio 3.4.0 (installed from conda-forge). Most of them (25 / 34) load successfully. I have opened upstream issues for those who don't.
|
39543a5 tof2d37ccComparef2d37cc to753f9c4Compare753f9c4 toe976856Comparec86480a to39f4a0dCompareAs of today, the Pinocchio version on PyPI is 2.7.0 while that onconda-forge is 3.3.0
Merge remaining loader tests to the description test fixture.
39f4a0d tod68f8d3CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Blocker: the
pinpackage on PyPI is currently at version 2.7.0, while we will need a version that includesthis change to be able to test MJCF descriptions here.