Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: correct variable name in pixel_tokens_with_pos_embed reshape operation#448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lixiaolei1982 wants to merge1 commit intoroboflow:develop
base:develop
Choose a base branch
Loading
fromlixiaolei1982:fix/incorrect-variable-name

Conversation

@lixiaolei1982
Copy link

Description

Fixed incorrect variable name in pixel_tokens_with_pos_embed reshaping operation wherenum_h_patches_per_window was used instead ofnum_w_patches_per_window for the width dimension.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Change:num_h_patches_per_windownum_w_patches_per_window in the fourth dimension of reshape operation
  • File:rfdetr/models/backbone/dinov2_with_windowed_attn.py
  • Line: ~315

Code Comparison

Before:

windowed_pixel_tokens=pixel_tokens_with_pos_embed.reshape(batch_size*num_windows,num_h_patches_per_window,num_windows,num_h_patches_per_window,-1)**After:**```pythonwindowed_pixel_tokens=pixel_tokens_with_pos_embed.reshape(batch_size*num_windows,num_h_patches_per_window,num_windows,num_w_patches_per_window,-1)## Impact-Improvescodereadabilityandconsistency-Nofunctionalchanges

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SkalskiPSkalskiPAwaiting requested review from SkalskiPSkalskiP is a code owner

@probicheauxprobicheauxAwaiting requested review from probicheauxprobicheaux is a code owner

@isaacrob-roboflowisaacrob-roboflowAwaiting requested review from isaacrob-roboflowisaacrob-roboflow is a code owner

@MatvezyMatvezyAwaiting requested review from MatvezyMatvezy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lixiaolei1982@CLAassistant

[8]ページ先頭

©2009-2025 Movatter.jp