Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/rkyvPublic

Revert "postgres-types feature implementation"#538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

novacrazy
Copy link
Contributor

Reverts#532

While I doubt rust-postgres/postgres-types willaccept my PR anytime soon, I realized forking individual crates and adding support to them in-crate is subpar compared to just forking rust-postgres/postgres-types itself, as shortly after my first PR I started getting confusing cyclic dependency errors due to patching so many individual crates, notably withsmol_str which rkyv also brings in if enabled. It feels kind of wrong to include this feature in the massive 0.8 release when it may be superseded later.

I sincerely apologize for the inconsistency/indecisiveness of this.

reneleonhardt reacted with thumbs up emoji
@novacrazy
Copy link
ContributorAuthor

Test failures are all unrelated, just bad timing as you're refactoring things.

@djkoloski
Copy link
Collaborator

Test failures are all unrelated, just bad timing as you're refactoring things.

Yep, I'll retrigger the CI as soon as the latest commit lands.

I sincerely apologize for the inconsistency/indecisiveness of this.

No need to be sorry! 🙂

@djkoloski
Copy link
Collaborator

Ah, looks like I don't have push rights on this branch of your fork. Could you rebase on main and force-push? In case you don't have an upstream remote yet:

git remote add upstream https://github.com/rkyv/rkyvgit fetch upstreamgit rebase upstream/maingit push --force

@novacrazynovacrazyforce-pushed therevert-532-postgres-types branch from33d7d76 to82c9e00CompareSeptember 5, 2024 19:31
@djkoloskidjkoloski merged commit478af0d intorkyv:mainSep 5, 2024
45 checks passed
@djkoloski
Copy link
Collaborator

Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@novacrazy@djkoloski

[8]ページ先頭

©2009-2025 Movatter.jp