Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork193
Revert "postgres-types feature implementation"#538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Test failures are all unrelated, just bad timing as you're refactoring things. |
Yep, I'll retrigger the CI as soon as the latest commit lands.
No need to be sorry! 🙂 |
Ah, looks like I don't have push rights on this branch of your fork. Could you rebase on main and force-push? In case you don't have an upstream remote yet:
|
This reverts commit158a5cc.
33d7d76
to82c9e00
Compare478af0d
intorkyv:mainUh oh!
There was an error while loading.Please reload this page.
Thank you! |
Reverts#532
While I doubt rust-postgres/postgres-types willaccept my PR anytime soon, I realized forking individual crates and adding support to them in-crate is subpar compared to just forking rust-postgres/postgres-types itself, as shortly after my first PR I started getting confusing cyclic dependency errors due to patching so many individual crates, notably with
smol_str
which rkyv also brings in if enabled. It feels kind of wrong to include this feature in the massive 0.8 release when it may be superseded later.I sincerely apologize for the inconsistency/indecisiveness of this.