- Notifications
You must be signed in to change notification settings - Fork417
add support for OpenSSL 1.1#444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -119,12 +129,14 @@ bool CryptoKey::loadFromFile(const QString &path, KeyType type, KeyFormat format | |||
| bool CryptoKey::isPrivate() const | |||
| { | |||
| return isLoaded() && d->key->p != 0; | |||
| const BIGNUM *p, *q; | |||
| RSA_get0_factors(d->key, &p, &q); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will crash in the!isLoaded() case
Otherwise, I think this looks ok. We'll want to try building with LibreSSL and make sure that still works too. Thanks! |
satta commentedAug 16, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think my latest addition addressed the issue you were raising. Thanks for the feedback! |
OpenSSL 1.1 introduces some API changes (https://wiki.openssl.org/index.php/1.1_API_Changes) which affect building of Ricochet. This PR adds some extra code to enable compiling with both the old and the new API.Please review carefully before merging!