- Notifications
You must be signed in to change notification settings - Fork288
Update build script to use GOFLAGS and CGO_LDFLAGS#460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This change makes use of GOFLAGS to simplify compiling with PIE, respecting LDFLAGS and trimming local paths to support reproducible builds.Relevant:https://lists.archlinux.org/pipermail/arch-dev-public/2020-March/029898.htmlSince you are already providing a source tarball that includes vendor dependencies (👍), all dependency-related items in the email do not apply to you:* -mod=vendor is used by default in Go 1.14* -modcacherw is only needed if our build system was fetching vendor dependencies itselfTested by applying this patch on top of 1.7.1 release archive that contains vendor folder.
ContributorAuthor
max-baz commentedMar 15, 2020
Oh it seems your travis checks for older Go versions... Let me know how you want to proceed, maybe it's time to remove older Go versions? 😜 |
rfjakob added a commit that referenced this pull requestApr 13, 2020
GOFLAGS exists since Go 1.11:https://golang.org/doc/go1.11#460
Owner
rfjakob commentedApr 18, 2020
-buildmode=pie causes problems with static builds: |
ContributorAuthor
max-baz commentedApr 18, 2020
Hmm I didn't see this, do you do something special to reproduce? |
Owner
rfjakob commentedApr 18, 2020
|
Owner
rfjakob commentedApr 18, 2020
Fixed via5da5e9f . build.bash now uses both -buildmode=pie and -trimpath when possible. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes use of GOFLAGS to simplify compiling with PIE, respecting LDFLAGS and trimming local paths to support reproducible builds.
Relevant:https://lists.archlinux.org/pipermail/arch-dev-public/2020-March/029898.html
Since you are already providing a source tarball that includes vendor dependencies (👍), all dependency-related items in the email do not apply to you:
Tested by applying this patch on top of 1.7.1 release archive that contains vendor folder.