Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34
up to python 3.10#269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ifisinstance(val,RqlQuery): | ||
| returnval | ||
| elifisinstance(val,collections.Callable): | ||
| elifisinstance(val,collections.abc.Callable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
change also needed for collections.Mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was fixed with#253.
gabor-boros left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR actually not updates the code to be python 3.10 compatible. Although the net_asyncio is "fixed", I'm not sure that the pinned dependencies, like tornado, supports python 3.10.
| self._parent.host, | ||
| self._parent.port, | ||
| loop=self._io_loop, | ||
| #loop=self._io_loop, droped at py3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This makes the driver backward incompatible with older python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It does? How so? The parameter was optional and otherwise it uses the active loop.
srh commentedOct 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Going to close, because, first, this only drops one of the loop parameters (there are a couple more that need to be dropped) and second, the change to And PR#296 removes all the loop params that need it. Also, the |
To use with python 3.10 some little changes are necesary.
Callable uses collections.abc
Drop loop arg