Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix deprecated import collections#253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gabor-boros merged 1 commit intorethinkdb:masterfrommetal3d:fix-252-abc-import
Sep 29, 2021

Conversation

@metal3d
Copy link
Contributor

Replace import collections to import collection.abc for Python >= 3.3

See issue#252

Reason for the change
See#252 forcollections deprecation

Description
collections is deprecated, we need to importcollections.abc

Note thatblack made some code fixes (indentation, import order...)

Checklist

References
Anything else related to the change e.g. documentations, RFCs, etc.

@metal3d
Copy link
ContributorAuthor

metal3d commentedMar 5, 2021•
edited
Loading

Afraid that no one continues to support this project...

gabor-boros
gabor-boros previously approved these changesMar 5, 2021
@metal3d
Copy link
ContributorAuthor

👍🏻@gabor-boros :)

@tirkarthi
Copy link

This was resolved in 2 to 3 branch :#187

Replace import collections to import collection.abc for Python >= 3.3See issuerethinkdb#252
@gabor-borosgabor-boros merged commit424cff7 intorethinkdb:masterSep 29, 2021
@gabor-boros
Copy link
Member

@metal3d Thank you for the contribution! Although a bit late, but approved and merged!

@metal3d
Copy link
ContributorAuthor

👍🏻 no problem

@Inveracity
Copy link
Contributor

@gabor-boros Now that 3.10 has been released will you cut a new release, please? It would be much appreciated, thank you <3

@gabor-boros
Copy link
Member

@Inveracity a massive refactor coming soon. I'll open the whip PR probably by Wednesday

Inveracity and lsabi reacted with heart emoji

@Inveracity
Copy link
Contributor

Heya@gabor-boros I'm curious if there has been any progress on the above?
Also is there an official channel for talking about joining the efforts?
I'd be very happy to help

@gabor-boros
Copy link
Member

@Inveracity Yes, we had some progress, though we are not ready yet with the changes. Feel free to join toDiscord orslack and ping me.

Inveracity reacted with thumbs up emoji

@srhsrh mentioned this pull requestOct 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gabor-borosgabor-borosgabor-boros approved these changes

+1 more reviewer

@tirkarthitirkarthitirkarthi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@metal3d@tirkarthi@gabor-boros@Inveracity
[8]ページ先頭
©2009-2025 Movatter.jp