Fix bug in Trio's`_read_exactly()`#213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gabor-boros merged 1 commit intorethinkdb:masterfrommehaase:trio_fix

Jun 15, 2020

Merged

Fix bug in Trio's`_read_exactly()`#213

gabor-boros merged 1 commit intorethinkdb:masterfrommehaase:trio_fix

Jun 15, 2020

Conversation

Copy link

Contributor

mehaase commentedJun 4, 2020

Reason for the change

The_read_exactly() method in the Trio driver sometimes fails on large responses, such as query results that contain lots of data.

Description

This method calls Trio'sreceive_some(n), which I found out can actually
return fewer thann bytes. This is only noticeable on large messages
(query results of around 80KB triggered the issue). The solution is to call
receive_some(...) in a loop untiln bytes has been received.

Code examples

n/a

Checklist

I have read and agreed to theRethinkDB Contributor License Agreement

References

n/a

Fix bug in Trio's _read_exactly()

99423c0

This method calls Trio's `receive_some(n)`, which I found out can actuallyreturn fewer than `n` bytes. This is only noticeable on large messages(query results of around 80KB triggered the issue). The solution is to call`receive_some(...)` in a loop until `n` bytes has been received.