Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Full rewrite for JSX4, records with optional fields + simplicity#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MoOx merged 1 commit intomainfromrewrite
Mar 21, 2023

Conversation

@cknitt
Copy link
Member

@cknittcknitt commentedFeb 7, 2023
edited
Loading

This is more or less a full rewrite of the existing bindings that I implemented for our company's projects in the last months.
It is meant for the latest ReScript (10.1.2) + @rescript/react 0.11.0 in JSX4 mode.

It

  • supports JSX4 (exclusively, although just the type definition for screenProps would need to be modified for JSX3)
  • uses records with optional fields instead of@obj creation functions for all options/config/param objects
  • has less runtime (zero cost except for a little glue for the variousNavigator.Make functions)
  • is more complete (I went through the props/params for the various navigators in the React Navigation docs and added lots of missing stuff. I am sure that there is still more missing stuff remaining though.)
  • is much simpler to use than the existing bindings. The existing ones are unnecessarily complicated by aparams type as an argument to theMake functor - which IMHO is of no use at all and actually incorrect, as not all screens in a stack navigator can be assumed to have the same params shape.

I currently do not have time for documentation or for a comprehensive example, so I am just putting this out there like it is.

reck753, mununki, namenu, and jeong-sik reacted with thumbs up emoji
@MoOxMoOx merged commit1837461 intomainMar 21, 2023
@MoOxMoOx deleted the rewrite branchMarch 21, 2023 16:00
@MoOx
Copy link
Member

How should we release this ? Any idea for the version number ?

@MoOxMoOx mentioned this pull requestMar 21, 2023
@Freddy03h
Copy link
Member

Freddy03h commentedMar 24, 2023
edited
Loading

It seems there is a coming 7.0 version of react-navigation, maybe we could wait for the others breaking changes.

react-navigation/react-navigation@ad722b8

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cknitt@MoOx@Freddy03h

[8]ページ先頭

©2009-2025 Movatter.jp