Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork13
create documentation of button component#22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's not just copy the page from RN website, this adds no value. We should instead focus on what is different from there docs.
docs/button.md Outdated
| A basic button component that should render nicely on any platform. Supports a minimal level of customization. | ||
| If this button doesn't look right for your app, you can build your own button using[TouchableOpacity](touchableopacity) or[TouchableWithoutFeedback](touchablewithoutfeedback). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pressable are recommended instead of Touchables.
docs/button.md Outdated
| ##Example | ||
| ```SnackPlayer name=Button%20Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Snack don't works on our website and can't.
Maybe a simple example without other component could be nice for a start, like for Text.
docs/button.md Outdated
| | Type| | ||
| | ----------------------------------| | ||
| | function([PressEvent](pressevent))| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
link don't work.
docs/button.md Outdated
| ##Props | ||
| ###<divclass="label required basic">Required</div>**`onPress`** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this css things doesn't work am I right?
@davisuga feel free to take this and address issue I mentioned :) |
documentation of button component based in the doc of react-native with samples