Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

deprecate other @obj#825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Freddy03h merged 2 commits intomainfromdeprecate_obj
Jan 17, 2025
Merged

deprecate other @obj#825

Freddy03h merged 2 commits intomainfromdeprecate_obj
Jan 17, 2025

Conversation

@Freddy03h
Copy link
Member

@Freddy03hFreddy03h commentedDec 13, 2024•
edited
Loading

I deprecate some missing@obj on the project but I can't decide what to do with some of them.

Example withtransform

typetransform@objexternalperspective: (~perspective:float)=>transform=""@objexternalrotate: (~rotate:angle)=>transform=""@objexternalrotateX: (~rotateX:angle)=>transform=""@objexternalrotateY: (~rotateY:angle)=>transform=""@objexternalrotateZ: (~rotateZ:angle)=>transform=""@objexternalscale: (~scale:float)=>transform=""@objexternalscaleX: (~scaleX:float)=>transform=""@objexternalscaleY: (~scaleY:float)=>transform=""@objexternaltranslateX: (~translateX:size)=>transform=""@objexternaltranslateY: (~translateY:size)=>transform=""@objexternalskewX: (~skewX:angle)=>transform=""@objexternalskewY: (~skewY:angle)=>transform=""

In the react-native doc it's:

array of objects:{matrix: number[]},{perspective: number},{rotate: string},{rotateX: string},{rotateY: string},{rotateZ: string},{scale: number},{scaleX: number},{scaleY: number},{translateX: number},{translateY: number},{skewX: string},{skewY: string} or string

We cannot type it with@unboxed so I only see two strategies:

  1. Record with optional fields
typetransform= {rotate?:angle,scale?:float,translateX?:float,  …}

Pro: JS output is clean
Con: Can be error prone

  1. Variant
typetransform2=  |Rotate({rotate:angle})  |Scale({scale:float})  |TranslateX({translateX:float})

Pro: Enforce type
Con: JS output an object with aTAG field (even if we can cutomize it with@tag)

What's your opinion on it@cknitt ?

@Freddy03h
Copy link
MemberAuthor

@cknitt ?

@cknitt
Copy link
Member

Sorry for the late reply. I think we should stay with an abstract type for correctness.
Either keep things the way they are or maybe something like

typetransformtypeperspectiveTransform= {perspective:float}externalperspective:perspectiveTransform=>transform="%identity"typerotateTransform= {rotate:angle}externalrotate:rotateTransform=>transform="%identity"...

?

@Freddy03h
Copy link
MemberAuthor

Thank's for your reply!

I don't think there's a big difference between those two syntaxes. It's not enough to justify a rewriting imho.

lettransformStyle= [perspective(~perspective=2.0),scale(~scale=1.5)]
lettransformStyle= [perspective({perspective:2.0}),scale({scale:1.5})]

@Freddy03h
Copy link
MemberAuthor

Hi@cknitt, can I have a review? thanks :)

@Freddy03hFreddy03h merged commit4bf53fd intomainJan 17, 2025
2 checks passed
@Freddy03hFreddy03h deleted the deprecate_obj branchJanuary 17, 2025 10:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cknittcknittcknitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Freddy03h@cknitt
[8]ページ先頭
©2009-2025 Movatter.jp