Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix 0.69 not compiling on ReScript 10#773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MoOx merged 3 commits intomainfromfix-compilation-rescript-10
Oct 5, 2022

Conversation

@cknitt
Copy link
Member

Some errors were introduced in394bd60.

@cknittcknitt requested a review fromMoOxOctober 5, 2022 06:51
@MoOx
Copy link
Member

MoOx commentedOct 5, 2022

@cknitt I got a small diff on package-lock. Curious to know what version of npm you have :)

Copy link
Member

@MoOxMoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this fix !

@MoOxMoOx merged commite2847e7 intomainOct 5, 2022
@MoOxMoOx deleted the fix-compilation-rescript-10 branchOctober 5, 2022 10:15
@cknitt
Copy link
MemberAuthor

@cknitt I got a small diff on package-lock. Curious to know what version of npm you have :)

It seems I have 7.11.2.

@MoOx
Copy link
Member

MoOx commentedOct 5, 2022

That's the reason then.

❯ node --version && npm --versionv16.13.28.19.1

MoOx added a commit that referenced this pull requestOct 5, 2022
* main:  "end" is not a reserved word anymore  0.69.1  Fix 0.69 not compiling on ReScript 10 (#773)  0.69.0  Create HitSlop & Rect module (closes#765)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MoOxMoOxMoOx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cknitt@MoOx
[8]ページ先頭
©2009-2025 Movatter.jp